[Webkit-unassigned] [Bug 118306] [WTR] Should dump as text when the mimetype is text/plain

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118306





--- Comment #6 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-07-03 05:13:23 PST ---
(In reply to comment #5)
> (From update of attachment 205918 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205918&action=review
> 
> Please unskip tests in the same patch.
> 
> > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:876
> > +    WTF::String mimeType = toWTFString(adoptWK(WKBundleFrameCopyMIMETypeForResourceWithURL(frame, WKBundleFrameCopyURL(frame))));
> 
> This is leaking the return value of WKBundleFrameCopyURL().
> 

Ahh okay.

> > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:877
> > +    if (url.find("dumpAsText/") != WTF::notFound || mimeType == "text/plain")
> 
> Don't you mean "&& mimeType != "text/plain" ?

No, because we should dumpAsText if the "dumpAsText/" string is found (hence the first part) or if the mimeType is "text/plain"

In the dumpAsText(false) call the 'false' means do not dump pixels.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.