[Webkit-unassigned] [Bug 117834] [ATK] Adds support for aria-haspopup property.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117834





--- Comment #8 from Mario Sanchez Prada <mario at webkit.org>  2013-07-03 01:49:01 PST ---
(In reply to comment #7)
> > I wonder if it would be possible to implement the same functionality in DRT's AccessibilityUIElementAtk.cpp, so we can pass the test as well for WebKit1
> 
> WK1 support, done.

Cool, thanks

> > I would probably write this way:
> > 
> >   if (attributeValue.isNull() || attributeValue == "false")
> >     return false;
> > 
> >   return true;
> > 
> > ... but I'm fine with how it is now anyway. Your call.
> How about just return return attributeValue == "true" ? true : false;
> I guess operator overloading for String will take care in case of nulls

As I said, I'm fine with that too. Just sharing how I would probably do it, not necessarily meaning it's the best way to do it :).

In any case, if you're not checking nulls explicitly anyway then you could reduce it even more to a single statement:

  return attributeSetValueById(atk_object_get_attributes(ATK_OBJECT(m_element.get())), "aria-haspopup") == "true";

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.