[Webkit-unassigned] [Bug 117834] [ATK] Adds support for aria-haspopup property.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 01:25:28 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=117834





--- Comment #7 from Krzysztof Czech <k.czech at samsung.com>  2013-07-03 01:27:26 PST ---
> I wonder if it would be possible to implement the same functionality in DRT's AccessibilityUIElementAtk.cpp, so we can pass the test as well for WebKit1

WK1 support, done.
> 

> I would probably write this way:
> 
>   if (attributeValue.isNull() || attributeValue == "false")
>     return false;
> 
>   return true;
> 
> ... but I'm fine with how it is now anyway. Your call.
How about just return return attributeValue == "true" ? true : false;
I guess operator overloading for String will take care in case of nulls

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list