[Webkit-unassigned] [Bug 117834] [ATK] Adds support for aria-haspopup property.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117834





--- Comment #3 from Krzysztof Czech <k.czech at samsung.com>  2013-07-02 05:45:30 PST ---
(In reply to comment #2)
> (From update of attachment 205887 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205887&action=review
> 
> > Tools/ChangeLog:13
> > +        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
> > +        (WTR::attributeSetValueById):
> > +        (WTR::AccessibilityUIElement::stringAttributeValue):
> > +        (WTR::AccessibilityUIElement::hasPopup):
> 
> I wonder if it would be possible to implement the same functionality in DRT's AccessibilityUIElementAtk.cpp, so we can pass the test as well for WebKit1

Ohh I forgot, you are right, I'll do it.
> 
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1098
> > +    if (attributeValue.isNull())
> > +        return false;
> > +
> > +    return attributeValue == "true" ? true : false;
> 
> I would probably write this way:
> 
>   if (attributeValue.isNull() || attributeValue == "false")
>     return false;
> 
>   return true;
> 
> ... but I'm fine with how it is now anyway. Your call.
Nice hint, sounds good to me as well, I'll change it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.