[Webkit-unassigned] [Bug 117834] [ATK] Adds support for aria-haspopup property.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117834





--- Comment #2 from Mario Sanchez Prada <mario at webkit.org>  2013-07-02 05:37:32 PST ---
(From update of attachment 205887)
View in context: https://bugs.webkit.org/attachment.cgi?id=205887&action=review

> Tools/ChangeLog:13
> +        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
> +        (WTR::attributeSetValueById):
> +        (WTR::AccessibilityUIElement::stringAttributeValue):
> +        (WTR::AccessibilityUIElement::hasPopup):

I wonder if it would be possible to implement the same functionality in DRT's AccessibilityUIElementAtk.cpp, so we can pass the test as well for WebKit1

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1098
> +    if (attributeValue.isNull())
> +        return false;
> +
> +    return attributeValue == "true" ? true : false;

I would probably write this way:

  if (attributeValue.isNull() || attributeValue == "false")
    return false;

  return true;

... but I'm fine with how it is now anyway. Your call.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.