[Webkit-unassigned] [Bug 107881] webkit-patch rebaseline-expectations deletes TestExpectations file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107881





--- Comment #4 from Emil A Eklund <eae at chromium.org>  2013-01-25 10:01:40 PST ---
(In reply to comment #2)
> wow. does it leave a zero-length/empty file, or actually delete it?

Zero-length file.


> I should also note that when I've seen the "pretends to rebaseline" phenomenon before, it seems to be that the the baselines in your checkout actually match what the bots are producing (and so there's nothing to actually update). In this situation we silently delete the rebaseline line and move on, rather than logging something like "bots match your checkout, nothing to rebaseline". Perhaps the latter would be more useful?

Not sure. Executing "webkit-patch rebaseline <single test>" did rebaseline that test (but got the results mixed up between bots) so there certainly was work for it todo.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.