[Webkit-unassigned] [Bug 107881] webkit-patch rebaseline-expectations deletes TestExpectations file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 25 11:31:05 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=107881





--- Comment #5 from Dirk Pranke <dpranke at chromium.org>  2013-01-25 11:33:00 PST ---
(In reply to comment #4)
> (In reply to comment #2)
> > wow. does it leave a zero-length/empty file, or actually delete it?
> 
> Zero-length file.
> 

Okay, well, if the file consisted entire of lines marked with [ Rebaseline ], and the tool thought it rebaselined everything, then this is what I would've expected to happen.

Which at least reduces to the problem of "why did it only pretend to rebaseline"?

> 
> Not sure. Executing "webkit-patch rebaseline <single test>" did rebaseline that test (but got the results mixed up between bots) so there certainly was work for it todo.

Interesting. Offhand I can't guess why 'rebaseline' would do something but 'rebaseline-expectations' wouldn't, except that the bots were probably in different states. Not sure if that would've mattered.

I'll see if I can reproduce something like this. You don't by chance have a copy of the file marked up for rebaselining?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list