[Webkit-unassigned] [Bug 108690] Add ImageFrameCache to facilitate access to ImageFrames

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 19:48:53 PST 2013


--- Comment #24 from Stephen White <senorblanco at chromium.org>  2013-02-13 19:51:08 PST ---
(In reply to comment #23)
> I think our options are:
> 1. Add more #if USE(SKIA) in ImageDecoder.h and implement in ImageDecoderSkia.cpp Which I do no prefer.

I don't think it would be that bad.  You'd be adding two more function declarations to an existing #if USE(SKIA) block, and two more implementations to ImageDecoderSkia.cpp.

> 2. Isolate ImageFrame and ImageFrameCache from ImageDecoder.h. Have #ifdefs in ImageFrame.h ImageFrameCache.h. Chromium specific features will be implemented in ImageFrame and ImageFrameCache and not ImageDecoder.

I don't really see the difference.  You still need the #ifdefs, you've just put them in a different (but still platform-common) file.

> I don't think inheriting ImageFrame is the right approach here. It is supposed to be the platform layer.

Inheritance is not the pattern used by the WebKit platform layer, in general.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list