[Webkit-unassigned] [Bug 108690] Add ImageFrameCache to facilitate access to ImageFrames

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 19:52:37 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=108690





--- Comment #25 from Hin-Chung Lam <hclam at google.com>  2013-02-13 19:54:52 PST ---
(In reply to comment #24)
> (In reply to comment #23)
> > I think our options are:
> > 
> > 1. Add more #if USE(SKIA) in ImageDecoder.h and implement in ImageDecoderSkia.cpp Which I do no prefer.
> 
> I don't think it would be that bad.  You'd be adding two more function declarations to an existing #if USE(SKIA) block, and two more implementations to ImageDecoderSkia.cpp.

Okay I have no objection to this if you like this better.

Which means:

1. ImageDecoder should have a resizeFrameCache method. That we can implement a platform specific version to assign allocator in ImageDecoderSkia.cpp.

2. Have lock / unlock in ImageDecoder under #if USE(SKIA).

Min do you think this is reasonable? Sorry for making you do all this work..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list