[Webkit-unassigned] [Bug 105348] XMLHttpRequestProgressEventThrottle::resume() always schedules timer even when unnecessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 14:24:46 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105348


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #187607|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2013-02-11 14:26:59 PST ---
(From update of attachment 187607)
View in context: https://bugs.webkit.org/attachment.cgi?id=187607&action=review

Looks right to me.

> Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp:202
> +        // There is no deferred event. Let's clear the flag now.

I don't think that this comment is useful. It just describes what the code does.

Please remove the comment before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list