[Webkit-unassigned] [Bug 109490] New: webkit-patch land-safely's --reviewer flag puts mental sanity at risk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 14:26:29 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109490

           Summary: webkit-patch land-safely's --reviewer flag puts mental
                    sanity at risk
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: michelangelo at webkit.org
                CC: jchaffraix at webkit.org


When landing with land-safely --reviewer="SOMETHING" the SOMETHING token seems to be taken literally.

TO REPRODUCE:
Try to land a patch with webkit-patch land-safely --reviewer="somereviewer at webkit.org"

WHAT HAPPENS:
The ChangeLogs are populated with "Reviewed by somereviewer at webkit.org"

WHAT SHOULD HAPPEN INSTEAD
A reverse look-up of the --reviewer flag content should take place, populating the ChangeLogs with reviewer's FULL NAME.

NOTES:
For a picture of a great moment take a look at https://bugs.webkit.org/show_bug.cgi?id=106927

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list