[Webkit-unassigned] [Bug 91440] Implement 'vmin' and 'vmax' from CSS3 values and units

Wed Feb 6 10:48:41 PST 2013

https://bugs.webkit.org/show_bug.cgi?id=91440

Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #185030|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |

--- Comment #8 from Antti Koivisto <koivisto at iki.fi>  2013-02-06 10:50:48 PST ---
(From update of attachment 185030)
View in context: https://bugs.webkit.org/attachment.cgi?id=185030&action=review

r=me with the tests fixed

> LayoutTests/css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-expected.html:19
> +<!DOCTYPE>
> +<html>
> +<style>
> + #element-container-vmax {
> +   background:green;
> + }
> +</style>
> +<div id="element-container-vmax">TEST PASSED</div>
> +<script>
> +function applyStyle() {
> +    var viewportMaxLength = Math.max(window.innerWidth, window.innerHeight);
> +    var elementStyle = document.getElementById("element-container-vmax").style;
> +    elementStyle.height = Math.floor(30 * viewportMaxLength / 100) + "px";
> +    elementStyle.width = Math.floor(30 * viewportMaxLength / 100) + "px";
> +    elementStyle.fontSize = Math.floor(3 * viewportMaxLength / 100) + "px";
> +    elementStyle.lineHeight = Math.floor(4 * viewportMaxLength / 100) + "px";
> +    elementStyle.textIndent = Math.floor(2 * viewportMaxLength / 100) + "px";
> +    elementStyle.marginLeft = Math.floor(2 * viewportMaxLength / 100) + "px";
> +    elementStyle.marginRight = Math.floor(2 * viewportMaxLength / 100) + "px";

Your tests and result files seems to have traded places. -expected.html has script in it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.