[Webkit-unassigned] [Bug 108899] Coordinated Graphics : Refactor GraphicsSurface and ShareableBitmap to be responsible for their GraphicsContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108899





--- Comment #17 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-02-18 16:20:55 PST ---
(From update of attachment 188836)
View in context: https://bugs.webkit.org/attachment.cgi?id=188836&action=review

> Source/WebCore/platform/graphics/surfaces/GraphicsSurface.cpp:52
> +    m_graphicsContexts.append(createGraphicsContext(rect.size(), bits, stride));

It seems wrong to be able to create more than one GraphicsContext for a given surface. What happens when painting is interleaved from the two contexts?

> Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h:88
> +    GraphicsContext* beginPaint(const IntRect&, LockOptions);
> +    void endPaint();

Why not just create a GraphicsContext* when first asked, then keep it around? Forcing clients to call endPaint() is a bit burdensome.

> Source/WebKit2/Shared/ShareableBitmap.h:173
> +    Vector<OwnPtr<WebCore::GraphicsContext> > m_graphicsContexts;

Same comment here. Why allow more than one context?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.