[Webkit-unassigned] [Bug 109268] [v8] isolate parameter added to all v8::peristent calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109268





--- Comment #8 from Dan Carney <dcarney at google.com>  2013-02-08 01:17:23 PST ---
(From update of attachment 187256)
View in context: https://bugs.webkit.org/attachment.cgi?id=187256&action=review

>> Source/WebCore/bindings/v8/ScopedPersistent.h:60
>>      void set(v8::Handle<T> handle)
> 
> This should receive an Isolate. If call sites are too many, you can fix it in a follow-up patch (please just add FIXME).

I checked. Too many calls site for this patch.

>> Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:76
>> +    return v8::Persistent<v8::String>::New(v8::Isolate::GetCurrent(), v8::String::NewSymbol(key));
> 
> I think this can be fixed.

Too many call sites for this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.