[Webkit-unassigned] [Bug 109268] [v8] isolate parameter added to all v8::peristent calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109268





--- Comment #7 from Dan Carney <dcarney at google.com>  2013-02-08 01:16:12 PST ---
(In reply to comment #6)
> Understood. No FIXME is OK. But I'm not quite happy with a lot of Isolate::GetCurrent()s with "let's fix it later". Alternately, you can first land patches that pass an Isolate around so that you don't need to write Isolate::GetCurrent() too much.

We'd prefer a mechanical replacement of all calls with a Isolate::GetCurrent() unless an isolate parameter is already available.  After all calls are replaced, then it will be easier to analyze which calls need an isolate parameter, and which classes need an isolate member added.  Doing it in stages might not be optimal and will slow down this work.  Adding Isolate::GetCurrent() adds no overhead, and we WILL remove all calls to GetCurrent() in the future, since it will no longer do what it used to do once the v8 api is changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.