[Webkit-unassigned] [Bug 105478] Implemet :lang() pseudo class support for the WebVTT ::cue pseudo element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105478





--- Comment #13 from Darin Adler <darin at apple.com>  2013-02-04 13:15:08 PST ---
(From update of attachment 186209)
View in context: https://bugs.webkit.org/attachment.cgi?id=186209&action=review

> Source/WebCore/css/SelectorChecker.cpp:825
> +                    value = element->getAttribute(langAttr);

Should probably be fastGetAttribute.

Are we guaranteed that there is always a lang attribute in WebVTT? Would we ever want to compute the inherited language instead?

Is there a way to factor this so we don’t have to put this code into CSS? Maybe a virtual function?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.