[Webkit-unassigned] [Bug 105478] Implemet :lang() pseudo class support for the WebVTT ::cue pseudo element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105478





--- Comment #14 from Dima Gorbik <dgorbik at apple.com>  2013-02-04 13:37:21 PST ---
(In reply to comment #13)
> (From update of attachment 186209 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186209&action=review
> 
> > Source/WebCore/css/SelectorChecker.cpp:825
> > +                    value = element->getAttribute(langAttr);
> 
> Should probably be fastGetAttribute.
> 
> Are we guaranteed that there is always a lang attribute in WebVTT? Would we ever want to compute the inherited language instead?
> 
> Is there a way to factor this so we don’t have to put this code into CSS? Maybe a virtual function?

According to specs lang attribute should only exist for lang webvtt objects. We should store the language internally to all other nodes, so we will not get this attribute. This is something I have to modify soon. Specs also require to precalculate on the parsing stage so we probably will never do it the same way as we do for html elements. 
Renaming computeInheritedLanguage() function and making it virtual is a good idea, I will do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.