[Webkit-unassigned] [Bug 119929] Replace error-prone value with check from CSSProperty

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119929





--- Comment #2 from Bruno de Oliveira Abinader <bruno.d at partner.samsung.com>  2013-08-17 14:59:26 PST ---
(In reply to comment #1)
> What makes the static integer “error-prone” exactly? Maybe there’s some better justification here, or the wording of the justification is confusing?

What I wanted to meant was that the same check is already implemented on CSSProperty::isInheritedProperty(). By using a static integer value, we are (1) duplicating code checks, and (2) more vulnerable to errors: one can add/remove a non-inherited property but forget to update the static integer value, or add a new property in the wrong place (i.e. after the integer value specified). By having a runtime check (like the one already implemented in CSSProperty), we can no longer worry about where to put the property in the vector, or update the integer value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.