[Webkit-unassigned] [Bug 119929] Replace error-prone value with check from CSSProperty

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119929





--- Comment #3 from Darin Adler <darin at apple.com>  2013-08-18 19:29:17 PST ---
(In reply to comment #2)
> (1) duplicating code checks

Yes, the check should be shared and exist in only one place in the code, whether it’s based on a static integer or not.

> (2) more vulnerable to errors: one can add/remove a non-inherited property but forget to update the static integer value, or add a new property in the wrong place (i.e. after the integer value specified). By having a runtime check (like the one already implemented in CSSProperty), we can no longer worry about where to put the property in the vector, or update the integer value.

I am not completely convinced. It’s true that you could make errors before, but you can still make the error of adding a property and having it be treated as inherited when it should be treated as non-inherited. Is this benefit so good it’s worth runtime cost?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.