[Webkit-unassigned] [Bug 119537] The muted attribute in media element is not set before loading resource.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119537





--- Comment #9 from Jer Noble <jer.noble at apple.com>  2013-08-07 08:27:41 PST ---
(From update of attachment 208247)
View in context: https://bugs.webkit.org/attachment.cgi?id=208247&action=review

> LayoutTests/media/video-defaultmuted.html:27
>                  consoleWrite("<br>*** Test before setting src, IDL attribute should default to false");
> -                testMuted(false, defaultMuted);
> +                testMuted(defaultMuted, defaultMuted);

As you're changing the test, please also change the description above the test.  It no longer accurately describes the test that follows.

> LayoutTests/media/video-defaultmuted.html:41
> -                    testMuted(defaultMuted, newDefaultMuted);
> +                    // If muted attribute is existed, changed value of defaultMuted do not reflect the muted attribute.
> +                    // if muted atrribute is not existed, value of defaultMuted reflect the muted attribute.
> +                    testMuted(true, newDefaultMuted);

These comments do not make sense. I think I understand what you're trying to say here, but if it's true that "video.muted == true" in all cases, this belongs in the consoleWrite() above.

> LayoutTests/media/video-defaultmuted.html:55
> -                    testMuted(false, video.hasAttribute('muted'));
> +                    testMuted(!defaultMuted, video.hasAttribute('muted'));

Again, this no longer matches the message above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.