[Webkit-unassigned] [Bug 119537] The muted attribute in media element is not set before loading resource.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119537


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #208247|review?                     |review-
               Flag|                            |




--- Comment #10 from Eric Carlson <eric.carlson at apple.com>  2013-08-07 09:37:35 PST ---
(From update of attachment 208247)
View in context: https://bugs.webkit.org/attachment.cgi?id=208247&action=review

Thank you for fixing this!

The patch is close, but not quite there yet.

> Source/WebCore/ChangeLog:14
> +        (WebCore::HTMLMediaElement::parseAttribute):
> +        (WebCore::HTMLMediaElement::loadResource):

Please add comments describing what changed in each method.

> LayoutTests/media/video-defaultmuted-expected.txt:11
>  *** Test before setting src, IDL attribute should default to false

This comment is incorrect, maybe quote the spec text instead - "When a media element is created, if it has a muted attribute specified, the user agent must mute the media element's audio output, overriding any user preference."

> LayoutTests/media/video-defaultmuted-expected.txt:68
>  *** Add 'muted' content attribute, it should have no effect on IDL attribute
>  RUN(video.setAttribute('muted', 'muted'))
> -EXPECTED (video.muted == 'false') OK
> +EXPECTED (video.muted == 'true') OK

This no longer tests anything, because video.muted is already true before setting the content attribute. Set video.muted to false before setting the content attribute to make sure it is not changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.