[Webkit-unassigned] [Bug 115138] [QNX][ARM] Use hardware integer division where available

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 24 20:48:41 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115138


Cosmin Truta <ctruta at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #199607|0                           |1
        is obsolete|                            |
 Attachment #199607|review?, commit-queue?      |
               Flag|                            |
 Attachment #199614|                            |review?, commit-queue?
               Flag|                            |




--- Comment #5 from Cosmin Truta <ctruta at gmail.com>  2013-04-24 20:46:59 PST ---
Created an attachment (id=199614)
 --> (https://bugs.webkit.org/attachment.cgi?id=199614&action=review)
Patch

I initially made DFG::isARMWithIntegerDiv() in order to use it as it's the case with DFG::isX86(), i.e. when it's not protected by #if CPU(...); but then I noticed I had used it inside in ARM-specific code also, interchangeably (and inconsistently) with MacroAssembler::supportsIntegerDiv(). I am now modifying the previous patch: I use MacroAssembler::supportsIntegerDiv() consistently inside ARM-specific code, and DFG::isARMWithIntegerDiv() only in the rare cases outside.

I also simplified isIntegerDivSupported().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list