[Webkit-unassigned] [Bug 115138] [QNX][ARM] Use hardware integer division where available
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 24 22:25:22 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=115138
Benjamin Poulain <benjamin at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #199614|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #6 from Benjamin Poulain <benjamin at webkit.org> 2013-04-24 22:23:41 PST ---
(From update of attachment 199614)
View in context: https://bugs.webkit.org/attachment.cgi?id=199614&action=review
Better but there is still some confusions with your flags.
> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.cpp:49
> +namespace JSC {
> +
> +static bool isIntegerDivSupported()
> +{
> +#if CPU(APPLE_ARMV7S)
> + return true;
> +#elif OS(QNX) && defined(ARM_CPU_FLAG_IDIV)
> + return !!(SYSPAGE_ENTRY(cpuinfo)->flags & ARM_CPU_FLAG_IDIV);
> +#else
> + return false;
> +#endif
> +}
> +
> +const bool MacroAssemblerARMv7::s_isIntegerDivSupported = isIntegerDivSupported();
This whole code could be in if OS(QNX).
You don't need ARMV7S and the fallback.
> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1921
> +
> + static const bool s_isIntegerDivSupported;
This should be in #if OS(QNX)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list