[Webkit-unassigned] [Bug 114941] Scrollbar should not depend on EventHandler, Frame and FrameView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 22 08:44:45 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=114941


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #199006|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2013-04-22 08:43:04 PST ---
(From update of attachment 199006)
View in context: https://bugs.webkit.org/attachment.cgi?id=199006&action=review

> Source/WebCore/ChangeLog:14
> +        It's a layering violation that Scrollbar uses EventHandler, Frame
> +        and FrameView. Frame is used to get the EvenHandler that is used
> +        to set mousePressed to false after a Scrollbar::mouseUp(). This is
> +        not really needed, since EvenHandler already sets m_mousePressed
> +        to false when calling Scrollbar::mouseUp(). The PopupMenu windows
> +        implementation also calls Scrollbar::mouseUp(), but that scrollbar
> +        is not inside a FrameView.

Some EvenHandler typos here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list