[Webkit-unassigned] [Bug 114941] Scrollbar should not depend on EventHandler, Frame and FrameView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114941





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-22 08:50:32 PST ---
(In reply to comment #2)
> (From update of attachment 199006 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199006&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        It's a layering violation that Scrollbar uses EventHandler, Frame
> > +        and FrameView. Frame is used to get the EvenHandler that is used
> > +        to set mousePressed to false after a Scrollbar::mouseUp(). This is
> > +        not really needed, since EvenHandler already sets m_mousePressed
> > +        to false when calling Scrollbar::mouseUp(). The PopupMenu windows
> > +        implementation also calls Scrollbar::mouseUp(), but that scrollbar
> > +        is not inside a FrameView.
> 
> Some EvenHandler typos here.

Ooops, will fix them before landing, thanks for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.