[Webkit-unassigned] [Bug 112834] [WebKit2] Plugins without a MIME Type fail to load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112834





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-18 23:37:21 PST ---
(In reply to comment #7)
> (From update of attachment 194759 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=194759&action=review
> 
> Som comments bellow + I think this deserve a test.

Sure, that's what's Anders told me, I was already looking at it.

> > Source/WebKit2/UIProcess/WebPageProxy.cpp:1333
> > -void WebPageProxy::getPluginPath(const String& mimeType, const String& urlString, const String& frameURLString, const String& pageURLString, String& pluginPath, uint32_t& pluginLoadPolicy)
> > +void WebPageProxy::getPluginPath(const String& mimeType, const String& urlString, const String& frameURLString, const String& pageURLString, String& pluginPath, String& newMimeType, uint32_t& pluginLoadPolicy)
> 
> The method become badly named with the addition.
> I think it is okay to have the new MIME type returned here, but not from a function named getPluginPath.

I agree, it probably become badly named when the policy parameter was added. What about findPlugin? What we are doing is calling PluginInfoStore::findPlugin() in the end.

> > Source/WebKit2/UIProcess/WebPageProxy.cpp:1337
> > -    String newMimeType = mimeType.lower();
> > +    newMimeType = mimeType.lower();
> 
> A bit unrelated but I am surprised you need to call lower() here. Usually, when handling MIME types in WebCore, we make them lower case as soon as we get the input for the user space.

Note that I haven't added the .lower(), it was already there, I don't know if it's needed, but I agree it should probably be done before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.