[Webkit-unassigned] [Bug 112834] [WebKit2] Plugins without a MIME Type fail to load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112834


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194759|review?                     |review-
               Flag|                            |




--- Comment #7 from Benjamin Poulain <benjamin at webkit.org>  2013-04-18 13:20:51 PST ---
(From update of attachment 194759)
View in context: https://bugs.webkit.org/attachment.cgi?id=194759&action=review

Som comments bellow + I think this deserve a test.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1333
> -void WebPageProxy::getPluginPath(const String& mimeType, const String& urlString, const String& frameURLString, const String& pageURLString, String& pluginPath, uint32_t& pluginLoadPolicy)
> +void WebPageProxy::getPluginPath(const String& mimeType, const String& urlString, const String& frameURLString, const String& pageURLString, String& pluginPath, String& newMimeType, uint32_t& pluginLoadPolicy)

The method become badly named with the addition.
I think it is okay to have the new MIME type returned here, but not from a function named getPluginPath.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1337
> -    String newMimeType = mimeType.lower();
> +    newMimeType = mimeType.lower();

A bit unrelated but I am surprised you need to call lower() here. Usually, when handling MIME types in WebCore, we make them lower case as soon as we get the input for the user space.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.