[Webkit-unassigned] [Bug 113132] [GTK] DOM objects created wrapping a base class have incorrect GObject type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113132





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-08 09:56:10 PST ---
(In reply to comment #5)
> (From update of attachment 194712 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=194712&action=review
> 
> Makes sense to me.

Thanks for the review.

> > Source/WebCore/bindings/gobject/WebKitDOMEventTargetPrivate.h:30
> > +WebKitDOMEventTarget* wrapEventTarget(WebCore::EventTarget*);
> 
> This doesn't seem to exist after the changes. Leftover?

hmm, that's right, EvenTarget is an interface, it shouldn't have a wrapEvenTarget method.

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1276
> >      my $lowerCaseIfaceName = "webkit_dom_" . FixUpDecamelizedName(decamelize($interfaceName));
> >      my $parentImplClassName = GetParentImplClassName($interface);
> > +    my $baseClass = GetBaseClass($parentImplClassName);
> 
> Nit: all the other variables have the 'Name' suffix, so it makes sense to keep the convention here.

Sure

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.