[Webkit-unassigned] [Bug 113132] [GTK] DOM objects created wrapping a base class have incorrect GObject type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113132


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194712|review?                     |review+
               Flag|                            |




--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2013-04-08 06:46:42 PST ---
(From update of attachment 194712)
View in context: https://bugs.webkit.org/attachment.cgi?id=194712&action=review

Makes sense to me.

> Source/WebCore/bindings/gobject/WebKitDOMEventTargetPrivate.h:30
> +WebKitDOMEventTarget* wrapEventTarget(WebCore::EventTarget*);

This doesn't seem to exist after the changes. Leftover?

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1276
>      my $lowerCaseIfaceName = "webkit_dom_" . FixUpDecamelizedName(decamelize($interfaceName));
>      my $parentImplClassName = GetParentImplClassName($interface);
> +    my $baseClass = GetBaseClass($parentImplClassName);

Nit: all the other variables have the 'Name' suffix, so it makes sense to keep the convention here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.