[Webkit-unassigned] [Bug 82714] WebSockets: The handshake should check for US-ASCII data instead of UTF-8.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82714





--- Comment #21 from Lamarque V. Souza <Lamarque.Souza at basyskom.com>  2013-04-02 16:11:26 PST ---
(In reply to comment #20)
> (In reply to comment #19)
> > Created an attachment (id=195463)
 --> (https://bugs.webkit.org/attachment.cgi?id=195463&action=review) [details] [details]
> > Patch
> > 
> > Simplify checks. The changes in the source code are small, please comment.
> 
> Good that now it fails on receiving bad handshake. (I'm not a WebKit reviewer)

I investigated mozilla/firefox's source and they do more checks than I do. However, some of their checks are for ancient webservers from the time of HTTP/0.9 and for a specific webserver that does answer properly to HTTP/1.1 requests (it returns HTTP/1.0 in its status line, which my test now checks for). Anyway, probably there must be very few webservers out there that does not understand/work properly with HTTP/1.1 nowadays.

> You made a fix on handshake-fail-by-prepended-null_wsh.py. Does this need to make it pass with this patch? handshake-fail-by-prepended-null_wsh.py is a stale test living since HyBi 00 era. We need to delete or change it to match the latest protocol, later.

Yes, the change is necessary because the extra status line checks I added triggers an error when running handshake-fail-by-prepended-null.html, which causes changes to handshake-fail-by-prepended-null-expected.txt. Jocelyn Turcotte suggested that I changed handshake-fail-by-prepended-null_wsh.py the way I did to make both my tests and handshake-fail-by-prepended-null.html to live together.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.