[Webkit-unassigned] [Bug 82714] WebSockets: The handshake should check for US-ASCII data instead of UTF-8.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 01:42:21 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=82714





--- Comment #20 from Takeshi Yoshino <tyoshino at google.com>  2013-04-02 01:40:32 PST ---
(In reply to comment #19)
> Created an attachment (id=195463)
 --> (https://bugs.webkit.org/attachment.cgi?id=195463&action=review) [details]
> Patch
> 
> Simplify checks. The changes in the source code are small, please comment.

Good that now it fails on receiving bad handshake. (I'm not a WebKit reviewer)

You made a fix on handshake-fail-by-prepended-null_wsh.py. Does this need to make it pass with this patch? handshake-fail-by-prepended-null_wsh.py is a stale test living since HyBi 00 era. We need to delete or change it to match the latest protocol, later.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list