[Webkit-unassigned] [Bug 96637] Remove V8DOMWindowShell::getEntered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96637


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #166385|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #41 from Adam Barth <abarth at webkit.org>  2012-09-30 08:57:22 PST ---
(From update of attachment 166385)
View in context: https://bugs.webkit.org/attachment.cgi?id=166385&action=review

> Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:180
> +    if (innerGlobal->InternalFieldCount() < V8DOMWindow::enteredIsolatedWorldIndex)

This is really fragile. There's no guarantee that the innerGlobal for a WorkerContext will have fewer internal fields than the innerGlobal for a DOMWindow.

It looks like this function used to only be called on the main thread. We probably need to avoid calling it on worker threads.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.