[Webkit-unassigned] [Bug 96637] Remove V8DOMWindowShell::getEntered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96637





--- Comment #42 from Dan Carney <dcarney at google.com>  2012-09-30 09:12:14 PST ---
(In reply to comment #41)
> (From update of attachment 166385 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166385&action=review
> 
> > Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:180
> > +    if (innerGlobal->InternalFieldCount() < V8DOMWindow::enteredIsolatedWorldIndex)
> 
> This is really fragile. There's no guarantee that the innerGlobal for a WorkerContext will have fewer internal fields than the innerGlobal for a DOMWindow.
> 
> It looks like this function used to only be called on the main thread. We probably need to avoid calling it on worker threads.

I'm not positive, but I believe it has always been used on both worker and main threads.  In the stack trace above, for instance, it is can called from a worked thread or a main thread.

I can change the if clause to check if we're on the main thread?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.