[Webkit-unassigned] [Bug 96508] [chromium] WebViewImpl::selectionBounds should return start/end on Android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96508





--- Comment #7 from Iain Merrick <husky at chromium.org>  2012-09-13 08:41:27 PST ---
Just had a chat offline about this with olilan (who wrote our text selection code for Android). There's a similar start/end swizzle in our Java code as well.

I think we could use *either* start/end or base/extent, we just need to be much clearer about which it is, and make sure we do the same thing consistently in all the APIs. The smallest change would be to use base/extent, as that's what most of the code already does (despite parameter names to the contrary). That means:

WebFrameImpl::selectRange() should take base and extent parameters
WebViewImpl::selectionBounds() should return base and extent

My new moveSelectionStart / moveSelection end methods wouldn't be needed.

I can go ahead and make a patch for that. Ryosuke, does that sound like a reasonable approach?

Also, can you explain the distinction between base/extent and anchor/focus? It looks to me like those are just the WebKit and HTML names for the same concepts, but maybe there's an important difference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.