[Webkit-unassigned] [Bug 96508] [chromium] WebViewImpl::selectionBounds should return start/end on Android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96508


Ryosuke Niwa (vacation: 8/26-9/10) <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #8 from Ryosuke Niwa (vacation: 8/26-9/10) <rniwa at webkit.org>  2012-09-13 11:01:47 PST ---
(In reply to comment #7)
> I think we could use *either* start/end or base/extent, we just need to be much clearer about which it is, and make sure we do the same thing consistently in all the APIs.

Yes.

> The smallest change would be to use base/extent, as that's what most of the code already does (despite parameter names to the contrary). That means:
> 
> WebFrameImpl::selectRange() should take base and extent parameters
> WebViewImpl::selectionBounds() should return base and extent

Okay but from the code, it appears that you're using anchor/focus instead.

> My new moveSelectionStart / moveSelection end methods wouldn't be needed.
> 
> I can go ahead and make a patch for that. Ryosuke, does that sound like a reasonable approach?

Sure. I'm happy as long as there isn't obnoxious if-endif depending on Android.

> Also, can you explain the distinction between base/extent and anchor/focus? It looks to me like those are just the WebKit and HTML names for the same concepts, but maybe there's an important difference.

Base/extent are different from anchor/focus when the user double or triple clicks on a page and creates a selection with granularity other than character. In such case, base/extent are at where the user clicked whereas anchor/focus will be extended to where the selection ends are.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.