[Webkit-unassigned] [Bug 63257] When blocking localStorage, Firefox throws a security exception on access, and maybe so should we

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63257





--- Comment #5 from jochen at chromium.org  2012-09-13 08:24:16 PST ---
(From update of attachment 163879)
View in context: https://bugs.webkit.org/attachment.cgi?id=163879&action=review

> Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp:46
> +        goto fail;

why don't you write something like

if (UNLIKELY(ec)) {
  setDOMException(ec, info.GetIsolate();
  return;
}

instead of the goto here and in the other places?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.