[Webkit-unassigned] [Bug 96001] [BlackBerry] Implement a color picker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96001


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162560|review?                     |review-
               Flag|                            |




--- Comment #9 from Rob Buis <rwlbuis at gmail.com>  2012-09-06 13:13:54 PST ---
(From update of attachment 162560)
View in context: https://bugs.webkit.org/attachment.cgi?id=162560&action=review

The comment needs to be fixed, and Cristophe's concern too.

> Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:88
> +    // Return -1 if user cancel the selection.

Comment is a bit wierd.

> Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:91
> +    static const char* cancelValue = "-1";

I dont like using -1 in a string. Or keeping a static var for it. You also still need to convert it to a String each time. Maybe an empty string can be used to cancel? But this does not need to be fixed with this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.