[Webkit-unassigned] [Bug 96001] [BlackBerry] Implement a color picker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96001





--- Comment #10 from Crystal Zhang <haizhang at rim.com>  2012-09-06 13:17:06 PST ---
(In reply to comment #8)
> (From update of attachment 162560 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162560&action=review
> 
> > Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp:105
> > +    writer.addData(m_source.utf8().data(), m_source.utf8().length());
> 
> My comment about caching m_source.utf8() in a local variable was still valid I believe. Any reason you did not fix it?
> Your copying the string twice here.

ok, will add it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.