[Webkit-unassigned] [Bug 97966] [WK2][GTK] Fix issues with WebKitFaviconDatabase in debug builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97966





--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-09-30 00:56:18 PST ---
(In reply to comment #0)
> After landing the patch for bug 96476 a couple of issues were spotted in debug builds:
> 
> The first one is that the ASSERT(!pageURL.isNull()) statement in webkitFaviconDatabaseGetFavicon() is wrong and should be replaced by an early return, since it won't be true whenever we ask a webview for its favicon before actually loading anything into it.

I don't think the assert is necessarily wrong, you should check in webkit_web_view_get_favicon() that the active URI is not NULL before calling webkitFaviconDatabaseGetFavicon(). so I think the early return should be in webkit_web_view_get_favicon().

> The second issue is that we must find a way to delete the temporary directory used to store the database in the unit tests *after* the IconDatabase from WebCore is closed (now it's closed when the WebKitFaviconDatabase is finalized), otherwise we will keep spotting the following disk I/O error in debug build when running TestWebKitFaviconDatabase in debug build:
> 
>    TEST: ./Tools/gtk/../Scripts/../../WebKitBuild/Debug/Programs/WebKit2APITests/TestWebKitFaviconDatabase... (pid=27818)
>      /webkit2/WebKitFaviconDatabase/set-directory:                        OK
>      /webkit2/WebKitFaviconDatabase/get-favicon:                          OK
>      /webkit2/WebKitFaviconDatabase/get-favicon-uri:                      OK
>      /webkit2/WebKitFaviconDatabase/clear-database:                       OK
>    ERROR: Could not create PageURL table in database (1802) - disk I/O error
>    ../../Source/WebCore/loader/icon/IconDatabase.cpp(1133) : void WebCore::createDatabaseTables(WebCore::SQLiteDatabase&)
> 
> Since those are related issues that must be fixed asap, I'm filing this bug now to keep track of them and propose (hopefully in 1-2 days from now) a fix for both of them

First issue can be fixed while landing patch for bug #96477

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.