[Webkit-unassigned] [Bug 97966] New: [WK2][GTK] Fix issues with WebKitFaviconDatabase in debug builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97966

           Summary: [WK2][GTK] Fix issues with WebKitFaviconDatabase in
                    debug builds
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: msanchez at igalia.com
                CC: mrobinson at webkit.org, cgarcia at igalia.com


After landing the patch for bug 96476 a couple of issues were spotted in debug builds:

The first one is that the ASSERT(!pageURL.isNull()) statement in webkitFaviconDatabaseGetFavicon() is wrong and should be replaced by an early return, since it won't be true whenever we ask a webview for its favicon before actually loading anything into it.

The second issue is that we must find a way to delete the temporary directory used to store the database in the unit tests *after* the IconDatabase from WebCore is closed (now it's closed when the WebKitFaviconDatabase is finalized), otherwise we will keep spotting the following disk I/O error in debug build when running TestWebKitFaviconDatabase in debug build:

   TEST: ./Tools/gtk/../Scripts/../../WebKitBuild/Debug/Programs/WebKit2APITests/TestWebKitFaviconDatabase... (pid=27818)
     /webkit2/WebKitFaviconDatabase/set-directory:                        OK
     /webkit2/WebKitFaviconDatabase/get-favicon:                          OK
     /webkit2/WebKitFaviconDatabase/get-favicon-uri:                      OK
     /webkit2/WebKitFaviconDatabase/clear-database:                       OK
   ERROR: Could not create PageURL table in database (1802) - disk I/O error
   ../../Source/WebCore/loader/icon/IconDatabase.cpp(1133) : void WebCore::createDatabaseTables(WebCore::SQLiteDatabase&)

Since those are related issues that must be fixed asap, I'm filing this bug now to keep track of them and propose (hopefully in 1-2 days from now) a fix for both of them

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.