[Webkit-unassigned] [Bug 91742] check-webkit-style crashes with OSError exception if SVN is not installed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91742


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org




--- Comment #8 from Eric Seidel <eric at webkit.org>  2012-09-15 10:01:08 PST ---
The patch is "fine" as is.  But it's not immediately clear to me what other callers might expect.  If you think all callers want this behavior than this is fine (we'd still like a unittest).  If you think that some might not, then it makes more sense to add the is_installed() helper instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.