[Webkit-unassigned] [Bug 91742] check-webkit-style crashes with OSError exception if SVN is not installed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91742





--- Comment #7 from Eric Seidel <eric at webkit.org>  2012-09-15 09:56:48 PST ---
(From update of attachment 153312)
When is this called?  Maybe we should just ahve a separate SVN.is_svn_installed() method that caller wants to check first?  Also, changes to the python generally unit tests (which should be easy to add here... We may have eto have this method take an optional filesystem/Executive parameter so it can be easily unittested with MockFileSystem, MockExecutive.

I suspect you didn't really want to get this involved in teh python code. :)  But testing it makes it so we don't break you in teh future.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.