[Webkit-unassigned] [Bug 90603] [EFL] Support the permission function of the Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90603


Kihong Kwon <kihong.kwon at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162471|commit-queue?               |
               Flag|                            |




--- Comment #40 from Kihong Kwon <kihong.kwon at samsung.com>  2012-09-06 07:37:53 PST ---
(From update of attachment 162471)
View in context: https://bugs.webkit.org/attachment.cgi?id=162471&action=review

>> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:73
>> +    PermissionsMap::iterator iter = m_cachedPermissions.find(context->securityOrigin()->toString());
> 
> We normally use 'it'

OK. I will change all iter to it.

>> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:82
>> +void NotificationPresenterClientEfl::addToPermissionCache(const String& domain, const bool permitted)
> 
> isPermitted

gyuyoung how do you think about this?
I accepted gyuyoung's opinion about this.
isPermitted? or permitted? :-)

>> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:87
>> +    m_cachedPermissions.add(domain, permitted);
> 
> That cannot be right, it never gets added

You are right.
I need to change this to (iter != m_cachedPermissions.end()).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.