[Webkit-unassigned] [Bug 90603] [EFL] Support the permission function of the Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90603





--- Comment #39 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-09-06 06:33:27 PST ---
(From update of attachment 162471)
View in context: https://bugs.webkit.org/attachment.cgi?id=162471&action=review

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:73
> +    PermissionsMap::iterator iter = m_cachedPermissions.find(context->securityOrigin()->toString());

We normally use 'it'

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:82
> +void NotificationPresenterClientEfl::addToPermissionCache(const String& domain, const bool permitted)

isPermitted

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:87
> +    PermissionsMap::iterator iter = m_cachedPermissions.find(domain);
> +    if (iter == m_cachedPermissions.end())
> +        return;
> +    m_cachedPermissions.add(domain, permitted);

That cannot be right, it never gets added

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.