[Webkit-unassigned] [Bug 100853] [V8] Cleanup V8DOMWrapper::getCachedWrapper

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 31 07:02:17 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=100853





--- Comment #2 from Kentaro Hara <haraken at chromium.org>  2012-10-31 07:03:36 PST ---
(From update of attachment 171643)
View in context: https://bugs.webkit.org/attachment.cgi?id=171643&action=review

> Source/WebCore/bindings/v8/V8DOMWrapper.h:-115
> -                v8::Persistent<v8::Object> wrapper = node->wrapper();
> -                if (LIKELY(!wrapper.IsEmpty()))

Why is this branch redundant? This branch will fail and has to fall back to the following slow path in a case where we are in the main world and a wrapper has not yet created for a given node, won't it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list