[Webkit-unassigned] [Bug 100853] [V8] Cleanup V8DOMWrapper::getCachedWrapper

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100853


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #171643|review?                     |review+
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2012-10-31 08:42:27 PST ---
(From update of attachment 171643)
View in context: https://bugs.webkit.org/attachment.cgi?id=171643&action=review

>> Source/WebCore/bindings/v8/V8DOMWrapper.h:-115
>> -                if (LIKELY(!wrapper.IsEmpty()))
> 
> Why is this branch redundant? This branch will fail and has to fall back to the following slow path in a case where we are in the main world and a wrapper has not yet created for a given node, won't it?

You're right Kentaro, but this function is only responsible for getting the cached wrapper.  The caller of this function will create the wrapper if this function returns an empty handle.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.