[Webkit-unassigned] [Bug 100321] Refactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 24 21:51:30 PDT 2012


--- Comment #7 from Mark Lam <mark.lam at apple.com>  2012-10-24 21:52:37 PST ---
(From update of attachment 170544)
View in context: https://bugs.webkit.org/attachment.cgi?id=170544&action=review

cloop changes look good to me.  Not so sure about some of the x86 changes though.

> Source/JavaScriptCore/offlineasm/x86.rb:56
> +        "*#{x86Operand(:quad)}"

What happens when we're building for 32-bit x86?  Shouldn't this be :ptr instead of :quad?

> Source/JavaScriptCore/offlineasm/x86.rb:251
> +        isX64 ? "*#{x86Operand(:quad)}" : "*#{x86Operand(:ptr)}"

Does isX64 necessarily mean we'll be using 64bit pointers?  Otherwise, it seems that this should always :ptr instead of :quad.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list