[Webkit-unassigned] [Bug 100321] Refactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100321





--- Comment #8 from Yuqiang Xian <yuqiang.xian at intel.com>  2012-10-24 21:58:23 PST ---
(In reply to comment #7)
> (From update of attachment 170544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=170544&action=review
> 
> cloop changes look good to me.  Not so sure about some of the x86 changes though.
> 
> > Source/JavaScriptCore/offlineasm/x86.rb:56
> > +        "*#{x86Operand(:quad)}"
> 
> What happens when we're building for 32-bit x86?  Shouldn't this be :ptr instead of :quad?
> 
> > Source/JavaScriptCore/offlineasm/x86.rb:251
> > +        isX64 ? "*#{x86Operand(:quad)}" : "*#{x86Operand(:ptr)}"
> 
> Does isX64 necessarily mean we'll be using 64bit pointers?  Otherwise, it seems that this should always :ptr instead of :quad.

Hi Mark, thanks for the review. For your questions on this couple of changes, I think comment #3 answers them?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.