[Webkit-unassigned] [Bug 99975] Remove ensureAuxiliaryContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99975





--- Comment #8 from Dan Carney <dcarney at google.com>  2012-10-23 01:34:54 PST ---
(In reply to comment #4)
> (From update of attachment 169867 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169867&action=review
> 
> > Source/WebCore/bindings/v8/V8Binding.cpp:313
> > +v8::Local<v8::Context> toV8Context(ScriptExecutionContext* context)
> 
> This function is too tempting for people to call, but it will often give the wrong result.  The problem is that you don't know which worlds context you want to return, especially if there is not JavaScript on the stack.  That's why the other version of this function requires a world context handle.

Okay, I've modified toV8Context to take a WorldToUse parameter instead.  It's much more efficient than the implicit conversion to WorldContextHandle that was happening before as it avoids a bunch of checks and the creation of a ScopedPersistent. I'd like to move all the toV8Context code eventually to WorldContextHandle from V8Binding, to make all this more clear.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.