[Webkit-unassigned] [Bug 99975] Remove ensureAuxiliaryContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99975


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170081|review?                     |review-
               Flag|                            |




--- Comment #9 from Adam Barth <abarth at webkit.org>  2012-10-23 10:20:38 PST ---
(From update of attachment 170081)
View in context: https://bugs.webkit.org/attachment.cgi?id=170081&action=review

> Source/WebCore/bindings/v8/V8Binding.cpp:322
> +            if (worldToUse == UseCurrentWorld) {
> +                if (V8DOMWindowShell* isolatedContext = V8DOMWindowShell::getEntered())
> +                    return v8::Local<v8::Context>::New(isolatedContext->context());
> +            }
> +            return frame->script()->mainWorldContext();

This seems wrong.  If we pass UseCurrentWorld but we're not in a V8 context, then we'll return the main world's context.  Perhaps this function should crash if we're not in a context?

The underlying problem is that the operation this function is trying to perform is impossible.  It's not possible to convert a ScriptExecutionContext to a v8::Context because there is a one-to-many relationship between ScriptExecutionContext and v8::Context.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.